[Merged by Bors] - Automatically serialize uuids #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again for the PR @mkawalec! What are your thoughts on also implementing JSValue for Uuid? |
Implement JSValue for Uuid, add examples
|
bors ping |
1 similar comment
|
bors ping |
|
pong |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
Behind an optional feature flag. Curiously enough it looks like I've found a cargo bug where having a feature named exactly the same as an optional crate, fails to pull in the optional crate. Fixed through a roundabout feature name on core. Co-authored-by: Michał Kawalec <ext.mkawalec@riotgames.com> Co-authored-by: Nick Mosher <nicholastmosher@gmail.com> Co-authored-by: Michal Kawalec <ext.mkawalec@riotgames.com>
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
Behind an optional feature flag. Curiously enough it looks like I've found a cargo bug where having a feature named exactly the same as an optional crate, fails to pull in the optional crate. Fixed through a roundabout feature name on core. Co-authored-by: Michał Kawalec <ext.mkawalec@riotgames.com> Co-authored-by: Nick Mosher <nicholastmosher@gmail.com> Co-authored-by: Michal Kawalec <ext.mkawalec@riotgames.com>
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
Behind an optional feature flag. Curiously enough it looks like I've found a cargo bug where having a feature named exactly the same as an optional crate, fails to pull in the optional crate. Fixed through a roundabout feature name on core. Co-authored-by: Michał Kawalec <ext.mkawalec@riotgames.com> Co-authored-by: Nick Mosher <nicholastmosher@gmail.com> Co-authored-by: Michal Kawalec <ext.mkawalec@riotgames.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behind an optional feature flag. Curiously enough it looks like I've found a cargo bug where having a feature named exactly the same as an optional crate, fails to pull in the optional crate. Fixed through a roundabout feature name on core.