-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sankore has wrong description or modifiers #29
Comments
How it actually works: FROM_OTHERS effect (GAIN_SCIENCE) always work with international TRs. TO_OTHERS can be used also for domestic ones. |
What is the expected behavior?
In other words, international TRs give 1g1s to sender and 2s to Sankore and domestic TRs provide 2s1f only to the wrong city. This is also how modifiers are constructed - OFFER & GAIN for international TRs and DOMESTIC for domestic ones. Now, there is a problem with FROM_OTHERS effect - it ignored domestic parameter. It means it is not possible to implement the situation where Sankore city gains the yields. Maybe Firaxis found it out and eventually changed the modifier type from FROM_OTHERS to TO_OTHERS. Because if there were no bug then Sankore city would be getting yields as expected and as the description says. Solution. Since the correct implementation is not possible then the only thing left is to update the description. |
Tried to use effect EFFECT_ADJUST_TRADE_ROUTE_YIELD_CHANGE that has AffectDestination and AffectOrigin params. Not working.
|
Summary:
There are 5 modifiers and 3 lines of description.
"TO_OTHERS" give gold and science to senders - this is ok
"2 science from others & not domestic" - ok
"2 science to others & domestic" - not ok (?) - it gives others, not us (?) ➡️ should be "from others"
faith is "to others & domestic" - also not ok, it gives others not us (?) ➡️ should be "from others"
From Firaxi's tweet revealing the University:
With Tokugawa: [...] getting a + 8 science from trade routes to my capital from each of my cities [...]
Also other civs rarely send routes: https://www.reddit.com/r/civ/comments/10edmhv/why_wont_other_civs_send_me_trade_routes_is/
The text was updated successfully, but these errors were encountered: