Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing integration test: Integration.Commands.ChartApiTests.GetTopArtists_Success #114

Open
rikkit opened this issue Apr 26, 2018 · 1 comment
Labels

Comments

@rikkit
Copy link
Member

rikkit commented Apr 26, 2018

https://ci.appveyor.com/project/rikkit/lastfm/build/1.0.999.323/tests

Error message:

  Expected: 30
  But was:  60

Error stack trace:

   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)
   at IF.Lastfm.Core.Tests.Integration.Commands.ChartApiTests.<GetTopArtists_Success>d__3.MoveNext() in C:\projects\lastfm\src\IF.Lastfm.Core.Tests.Integration\Commands\ChartGetTopTagsTests.cs:line 40
   at NUnit.Framework.AsyncInvocationRegion.AsyncTaskInvocationRegion.WaitForPendingOperationsToComplete(Object invocationResult)
   at NUnit.Core.NUnitAsyncTestMethod.RunTestMethod()
@rikkit rikkit added the testing label Apr 26, 2018
@rikkit rikkit added this to the 1.1 milestone Apr 26, 2018
@rikkit rikkit modified the milestones: 1.1, 1.1.1 Jul 1, 2018
@rikkit rikkit removed this from the 1.1.1 milestone Jan 29, 2019
@th0mk
Copy link
Contributor

th0mk commented Nov 18, 2019

While the integration tests can be useful, I'm not sure if its a good idea to include them in the build pipeline. Tests like these are pretty sensitive since they use real data and not mock data.

Also not sure if it's a good idea to have api key/secrets in the repo, but that's a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants