Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Data Explorer (TM) over from Enterprise Web #28

Closed
nhaugo opened this issue Sep 6, 2016 · 5 comments
Closed

Move Data Explorer (TM) over from Enterprise Web #28

nhaugo opened this issue Sep 6, 2016 · 5 comments
Assignees
Projects

Comments

@nhaugo
Copy link
Contributor

nhaugo commented Sep 6, 2016

In order to get the first version of Chronograf Nuevo up and running, we'll need to bring over a front end component to get the test suite up and running so that we can start building around the new toolchain. The first candidate that makes sense for this is the Data Explorer.

Here are the assumptions we can run with for this:

  • Continue using the existing visual design
  • Ignore all other sections of Enterprise Web - overview, user management, cluster management, etc
  • Assume that there is already a backend node/cluster configured (i.e. there is no requirement for configuration screens)
@nhaugo nhaugo self-assigned this Sep 6, 2016
@toddboom toddboom changed the title Move data explore from enterprise web Move Data Explorer (TM) over from enterprise web Sep 7, 2016
@toddboom toddboom changed the title Move Data Explorer (TM) over from enterprise web Move Data Explorer (TM) over from Enterprise Web Sep 7, 2016
@toddboom toddboom added the ready label Sep 7, 2016
@kfitzpatrick
Copy link
Contributor

Has a dependency on #5.

@wfro
Copy link

wfro commented Sep 7, 2016

Assume that there is already a backend node/cluster configured (i.e. there is no requirement for configuration screens)

Is this just a plutonium instance? Are we ready to start porting the data explorer to use the new backend (even if it's just swagger mocks)?

The actual porting should hopefully be straightforward. I do have a few questions, mostly around the data explorer's backend dependencies.

We need two backend things to consider the data explorer functional:

  • A server to save "sessions" to. Right now we just need a table with a name and a data field that stores a json blob.
  • An endpoint to sign and attach JWT tokens to InfluxDB queries (the client still requests all of the data nodes and picks which one to make each request to).

For this first pass should we:

  1. Keep things as simple as possible and use what we currently have (and possibly even mock query data)
  2. Start updating the frontend to use new endpoints

@nhaugo
Copy link
Contributor Author

nhaugo commented Sep 9, 2016

• There is no need to hook up to an actual data source, mocked data should be plenty to satisfy the goal.
• Sessions can be mocked as well. We should probably review the session object to ensure we are not carrying over unnecessary technical debt.
• Sessions can be temporary so buttons that write data can be left alone and do not need to function.
• The goal is to port over the ui not wire everything up.

@nhaugo nhaugo removed the ready label Sep 9, 2016
@nhaugo nhaugo removed their assignment Sep 9, 2016
@wfro
Copy link

wfro commented Sep 13, 2016

Thanks @nhaugo, this should be all set then. Once #1002 and #1036 make it into the enterprise code, hopefully by tomorrow, we can move the entire data explorer (it makes sense to do it there, there is work in progress on those two features so it's more difficult to move the code and then complete them).

@nhaugo nhaugo added the ready label Sep 13, 2016
@nhaugo
Copy link
Contributor Author

nhaugo commented Sep 13, 2016

Sounds good!

@willpiers willpiers self-assigned this Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants