Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a new query on a dashboard, the query editor should be highlighted by default #2265

Closed
russorat opened this issue Nov 4, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@russorat
Copy link
Contributor

russorat commented Nov 4, 2017

Right now, when a user starts to create a new graph on a dashboard, there is nothing highlighted (typing does nothing). If they are copying and pasting a query or are comfortable enough to start typing right away, we should highlight the query editor for them.

@cryptoquick
Copy link
Contributor

Easily done with a ref to the component and focus method call on componentDidMount.

@nhaugo nhaugo added this to the 1.4.x milestone Nov 6, 2017
@russorat russorat removed this from the 1.4.x milestone Apr 17, 2018
@russorat russorat added the epic/flux Issues for 1.7 flux release label Aug 9, 2018
@chnn chnn self-assigned this Aug 29, 2018
@chnn
Copy link
Contributor

chnn commented Aug 30, 2018

Just made a pass at this... ends up being much trickier due to a bug in codemirror and/or react-codemirror, which provides textbox in the query editor.

Going to punt on this for now.

@russorat
Copy link
Contributor Author

russorat commented Sep 4, 2018

@OfTheDelmer timebox this to .5 days to see if it is possible.

@russorat russorat assigned OfTheDelmer and unassigned chnn Sep 4, 2018
@russorat russorat added this to the 1.7.0 milestone Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants