Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks: should be able to find task by name #12170

Closed
2 tasks done
docmerlin opened this issue Feb 25, 2019 · 4 comments · Fixed by #14694
Closed
2 tasks done

tasks: should be able to find task by name #12170

docmerlin opened this issue Feb 25, 2019 · 4 comments · Fixed by #14694

Comments

@docmerlin
Copy link
Contributor

docmerlin commented Feb 25, 2019

tasks: should be able to find task by name
@goller asked that I add this.

  • Check swagger to understand how other resources are searched by name
    • This should determine the type of search (prefix, exact, wildcard, etc)
  • Replicate behavior for finding tasks
@goller
Copy link
Contributor

goller commented Feb 25, 2019

Here is a more context from @lyondhill

TaskService FindTasks currently doesn't support org name. It can be moved to the platform adapter if we wanted to update the FindTasks method in the interface.
Out of this context The FindTasks probably needs to be updated to use FindOptions sometime. When that happens would be a good time to move this out of the http handler.

#12022 (comment)

@lyondhill
Copy link
Contributor

lyondhill commented Feb 26, 2019

Task names are not unique. What is the consequence of finding a task with a non unique name? Would we error or return 'first'? Or maybe find task by name is a task list action?

@docmerlin
Copy link
Contributor Author

I figured it would be a task-list action. This does mean we need to re-add the index for task names, which means for backwards compatibility this needs to happen while we are still alpha, before the beta, unless we want to check versions and add indexing after the fact.

@stale
Copy link

stale bot commented Jul 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants