Add nil check for tagKeyValueEntry.setIDs() #13053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
force-pushed
the
bj-nil-check-setIDs-1.8
branch
from
f166a15
to
e0a7e42
Compare
benbjohnson
commented
Apr 1, 2019
Previously it was possible to set IDs on a `nil` entry which would in turn cause a panic. If this panic was recovered by the server then it would result in a mutex in the `inmem` index staying locked indefinitely.
benbjohnson
force-pushed
the
bj-nil-check-setIDs-1.8
branch
from
e0a7e42
to
2edbc90
Compare
This was referenced Apr 4, 2019
|
We're pretty much locked up in our PROD environment - we have the 1.7.3 RPM - can we somehow undo the upgrade to 1.7.5 and replace with 1.7.3 until this fix is published? |
|
Yes, you should be able to uninstall |
|
We downgraded to 1.7.3 and it's working so far. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to set IDs on a
nilentry which would in turn cause a panic. If this panic was recovered by the server then it would result in a mutex in theinmemindex staying locked indefinitely.Related: #13010
Briefly describe your proposed changes: