Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently apply env vars in CLI #16214

Closed
imogenkinsman opened this issue Dec 12, 2019 · 1 comment · Fixed by #16225
Closed

consistently apply env vars in CLI #16214

imogenkinsman opened this issue Dec 12, 2019 · 1 comment · Fixed by #16225
Assignees

Comments

@imogenkinsman
Copy link
Contributor

see #16048 for a list of env vars we use.

We use viper.BindEnv to access env vars for the CLI tool, but it isn't used in all places where it should be.

Investigate where env vars aren't being used in our CLI and add support in those places.

  • the tasks cli commands don't use env vars at all
  • the users cli commands also don't use env vars
  • possibly other places
@dearyhud
Copy link
Contributor

dearyhud commented Dec 12, 2019

did a quick ack around cmd and found these files not using viper.BindEnv in places where it should

cmd/influx/bucket.go
cmd/influx/authorization.go
cmd/influx/organization.go
cmd/influx/pkg.go
cmd/influx/setup.go

@jademcgough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants