Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test-go fails on ARM64 because of float comparisons #20294

Closed
danxmoran opened this issue Dec 9, 2020 · 1 comment
Closed

make test-go fails on ARM64 because of float comparisons #20294

danxmoran opened this issue Dec 9, 2020 · 1 comment
Labels
area/tests area/2.x OSS 2.0 related issues and PRs kind/bug

Comments

@danxmoran
Copy link
Contributor

Steps to reproduce:

  1. Check out influxdb on an ARM64 system
  2. Run make test-go

Expected behavior:
Tests pass. Any tests that deal with float comparisons either check a delta of allowable values, or round to a precision low enough to pass on both x86_64 and ARM64.

Actual behavior:
A handful of tests fail, with diffs that show mismatches in float values. The diffs I spot-checked were all in the ~15th digit after the decimal point.

@danxmoran
Copy link
Contributor Author

This has been fixed. Tests now run under ARM64 as part of PR validation to prevent bad comparisons from sneaking in again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests area/2.x OSS 2.0 related issues and PRs kind/bug
Projects
None yet
Development

No branches or pull requests

1 participant