Refactor backup & restore #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
force-pushed
the
backup-restore
branch
from
1e347b8
to
d82cc88
Compare
|
fixes #2812 ❓ |
|
@neonstalwart Yes. Thanks for tagging the issue. |
| if path == "" { | ||
| return url.URL{}, "", fmt.Errorf("snapshot path required") | ||
| // Ensure that only one arg is specified. | ||
| if fs.NArg() == 0 { |
There was a problem hiding this comment.
Minor -- this could be combined into a single check, if the error message was "a single snapshot path is required". This is purely a style issue.
There was a problem hiding this comment.
I went back and forth on it. I like the extra clarity. I don't have a terribly strong opinion about it though.
There was a problem hiding this comment.
Keep it your way. All good here.
|
A lot here, took a look, but don't grok it all. I do have one specific question about a WaitGroup. |
benbjohnson
force-pushed
the
backup-restore
branch
2 times, most recently
from
58bd109
to
d3d6d73
Compare
This commit updates the snapshot code as well as the "backup" and "restore" command to work with the new architecture.
benbjohnson
force-pushed
the
backup-restore
branch
from
d3d6d73
to
bc31783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request refactors the
influxd backupandinfluxd restorecommands to work with the new architecture. This involved adding additional protobuf support to themetapackage to serialize themeta.Datatree and refactoring snapshots into thesnapshotspackage and making them work with the new file layout.