Refactor map functions to use list of values #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
changed the title
benbjohnson
changed the title
benbjohnson
force-pushed
the
map-fn
branch
2 times, most recently
from
cb3c231
to
5614459
Compare
| max := &minMaxMapOut{} | ||
|
|
||
| pointsYielded := false | ||
| var val float64 | ||
|
|
||
| for k, v := itr.Next(); k != -1; k, v = itr.Next() { | ||
| switch n := v.(type) { | ||
| fmt.Printf("MAX======\n") |
There was a problem hiding this comment.
Debug code, I'm sure you want removed.
|
Seems fine, +1 once the debug code is removed. |
This commit changes `tsdb.mapFunc` to use `tsdb.MapInput` instead of an iterator. This will make it easier and faster to pass blocks of values from the new storage engine into the engine.
benbjohnson
added a commit
that referenced
this pull request
Sep 29, 2015
Refactor map functions to use list of values
|
@otoolep fixed & merged. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit changes
tsdb.mapFuncto usetsdb.MapInputinstead of an iterator. This will make it easier and faster to pass blocks of values from the new storage engine into the engine.