Single Server #5994
Merged
Single Server #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benbjohnson
commented
Mar 11, 2016
benbjohnson
commented
- CHANGELOG.md updated
- Rebased/mergable
- Tests pass
- Sign CLA (if not already signed)
This commit moves the `tsdb.Store.ExpandSources()` function onto the `influxql.IteratorCreator` and provides support for issuing source expansion across a cluster.
| @@ -330,7 +330,7 @@ func (bp *batchpoints) SetRetentionPolicy(rp string) { | |||
|
|
|||
| // Point represents a single data point | |||
| type Point struct { | |||
| pt models.Point | |||
There was a problem hiding this comment.
Why this change? pt was intentionally not exported for v2 client I believe.
There was a problem hiding this comment.
This was me. I needed this so I could easily create client.Point from an existing models.Point. The current NewPoint function relies on all the separate aspects of a point, which seemed clunky for the way I wanted to use the client.
There was a problem hiding this comment.
The problem is that the v2 client was intended to have points be immutable. Exporting the underlying Point defeats the purpose of that.
What about adding a function like:
NewPointFrom(pt models.Point) {
return &Point{pt:pt}
}
This commit moves the `tsdb.Store.ExpandSources()` function onto the `influxql.IteratorCreator` and provides support for issuing source expansion across a cluster.
e-dard
force-pushed
the
single-server-lite
branch
from
07eb551
to
207bafa
Compare
|
👍 |
2 similar comments
|
+1 |
|
👍 |
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.