Change to build process and a log message. #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build process was originally hard coded to use /tmp but some systems mount /tmp with noexec, causing the build to fail. This change allows the user (optionally) to specify a tmp dir. E.g., TMPDIR=~/tmp make
Originally it logged the same message when either the port or database config settings were wrong. Now it logs which setting was wrong.
|
Thanks @dgnorton for the fix. Do you mind signing the CLA in order for us to merge your pr. The CLA can be found on our website http://influxdb.com/community/cla.html. Let me know when you're done. |
|
Hi John, Sorry, I was up in the mountains without Internet access for a few days. David On Fri, Jun 20, 2014 at 10:35 AM, John Shahid notifications@github.com
|
jvshahid
added a commit
that referenced
this pull request
Jun 23, 2014
Change to build process and a log message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users with /tmp mounted with noexec to build without using sudo.
I just started playing with influxdb and felt one of the messages I saw in the log would be better with a little more detail.