Fixing panic in SHOW FIELD KEYS caused by 733a17d #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @e-dard to be a potential reviewer |
|
Needs changelog, but LGTM 👍 |
jsternberg
force-pushed
the
js-6659-panic-on-show-field-keys
branch
from
eb147fe
to
d979f60
Compare
The list of field keys in the index may have differed from the field keys in the actual shard. Fixing `SHOW FIELD KEYS` so it relies only on the shard rather than the index. Fixes #6659.
jsternberg
force-pushed
the
js-6659-panic-on-show-field-keys
branch
from
d979f60
to
946968b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of field keys in the index may have differed from the field
keys in the actual shard. Fixing
SHOW FIELD KEYSso it relies only onthe shard rather than the index.
Fixes #6659.