Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

influxql: $ character sometimes accepted as whitespace #7013

Closed
mark-rushakoff opened this issue Jul 14, 2016 · 2 comments
Closed

influxql: $ character sometimes accepted as whitespace #7013

mark-rushakoff opened this issue Jul 14, 2016 · 2 comments
Assignees
Milestone

Comments

@mark-rushakoff
Copy link
Contributor

Working from 921e4f5. There appear to be several cases where $ is accepted in a query, when it looks like it should be invalid:

> $show$databases
name: databases
---------------
name
_internal
z

> $show$measurements
name: measurements
------------------
name
m
t

> select*$from m
name: m
-------
time            i
1468529979248078256 0
@jsternberg jsternberg self-assigned this Jul 14, 2016
@jsternberg
Copy link
Contributor

@jwilder do you think we can get this into 1.0?

@jsternberg
Copy link
Contributor

This is not going to end up in 1.0. I'm setting the milestone for 1.1 and putting up a PR to get it into master.

@rkuchan until this is merged, there's going to be an issue with bound parameters. If you use a keyword like $SHOW, the scanner ignores the dollar sign and treats it as SHOW. This applies to any keyword. Everything else should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants