Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mmap dereferencing #7196

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Fix mmap dereferencing #7196

merged 1 commit into from
Aug 24, 2016

Conversation

benbjohnson
Copy link
Contributor

@benbjohnson benbjohnson commented Aug 23, 2016 •
edited
Loading

Overview

Adds a missing dereference call to Close() as well as fixes a tag copy issue.

Fixes #7183, #7180

/cc @jwilder

TODO

  • Rebased/mergable
  • Tests pass

@jwilder jwilder added this to the 1.1.0 milestone Aug 24, 2016
@jwilder
Copy link
Contributor

jwilder commented Aug 24, 2016

Can you add #7183 and #7180 to the changelog as fixed? Otherwise, 👍

@benbjohnson
Fix mmap dereferencing
cc628a1 
Adds a missing dereference call to `Close()` as well as fixes
a tag copy issue.
@benbjohnson
Copy link
Contributor Author

@jwilder Fixed. Merging.

@benbjohnson benbjohnson merged commit a30f9b6 into influxdata:master Aug 24, 2016
@benbjohnson benbjohnson deleted the mmap-fix branch August 24, 2016 16:48
@liv3d liv3d mentioned this pull request Aug 27, 2016
Closed
@jwilder jwilder mentioned this pull request Sep 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/tsm
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Panic during shutdown
2 participants
@benbjohnson @jwilder