Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stddev function accepts strings #7436

Closed
Tomcat-Engineering opened this issue Oct 9, 2016 · 2 comments
Closed

Stddev function accepts strings #7436

Tomcat-Engineering opened this issue Oct 9, 2016 · 2 comments
Assignees
Milestone

Comments

@Tomcat-Engineering
Copy link
Contributor

This line in the source code specifically allows the stddev (standard deviation) function to accept time series of datatype "string".

Obviously there is no sensible way to take the standard deviation of a load of strings, and the implementation always returns an empty string.

This is inconsistent with all the other comparable functions (such as mean), which throw an error if you feed them strings.

Was there a reason for this special case?

@jsternberg
Copy link
Contributor

Looks like the piece of code that allows stddev() to operate on strings has been there since the beginning and I can't find a commit that explains why from a quick look.

@benbjohnson do you have any idea?

@benbjohnson
Copy link
Contributor

@jsternberg I can't think of any reason to use a string. We can remove that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants