Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edits to /etc/config.sample.toml #8358

Closed
timhallinflux opened this issue May 4, 2017 · 5 comments
Closed

Small edits to /etc/config.sample.toml #8358

timhallinflux opened this issue May 4, 2017 · 5 comments

Comments

@timhallinflux
Copy link
Contributor

timhallinflux commented May 4, 2017

Bug report

System info: InfluxDB v1.2.2

Three issues:

  1. [coordinator]
# The maximum number of series a SELECT can run.  A value of 0 will make the maximum series
# count unlimited.

Next line should be:

#max-select-series = 0
  1. [http]
# Determines whether HTTP authentication is enabled.
# auth-enabled = false

This is a little confusing as the setting applies equally to situations where HTTPS is enabled, so I would propose "HTTP/HTTPS" to avoid confusion. Otherwise it really does look like you're saying "auth only with http... but what about https?")

  1. [http]
# Determines whether HTTP request logging is enable.d
# log-enabled = true

should read:

# Determines whether HTTP request logging is enabled.
# log-enabled = true
@jsternberg
Copy link
Contributor

jsternberg commented May 8, 2017

I'm a bit confused by the first. I see this in the current file:

  # The maximum number of series a SELECT can run. A value of zero will make the maximum series
  # count unlimited.
  # max-select-series = 0

What's wrong with that? The only difference I see is the lack of a space between # and max-select-series.

@jsternberg
Copy link
Contributor

Also, for the second, should we not make a reference to HTTP? It makes it sound like the authentication has something to do with HTTP rather than it being authentication used over HTTP. Maybe it should read: Determines whether user authentication is enabled over HTTP/HTTPS.

@timhallinflux
Copy link
Contributor Author

agreed.. it should read ...enabled over HTTP/HTTPS.

@jsternberg
Copy link
Contributor

Never mind on the first. I think I found the issue:

  # The maximum number of series a SELECT can run.  A value of 0 will make the maximum series
  # count unlimited.

  # The maximum number of series a SELECT can run. A value of zero will make the maximum series
  # count unlimited.
  # max-select-series = 0

@timhallinflux
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants