Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.11.1]: admin UI does not provide any feedback for successful but empty queries #6193

Closed
jonseymour opened this issue Apr 4, 2016 · 3 comments

Comments

@jonseymour
Copy link
Contributor

Bug report

System info:

influxdb: 0.11.1 (local build)
operating systemn: ubuntu 14.04.4

Steps to reproduce:

  1. execute a query that is expected to have no results: select * from "database" where numSeries < 0

Expected behavior: [What you expected to happen]

A success message should be displayed, indicating that the query was accepted and processed successfully but no results were returned.

Actual behavior: [What actually happened]

No results are displayed and no feedback is available to indicate to the user that the query was even accepted. Previously a green success message was displayed.

Other examples include:

CREATE DATABASE foobar
DROP DATABASE foobar
SHOW SUBSCRIPTIONS # when there are no subscriptions

The CREATE DATABASE and DROP DATABASE cases also fail to report an error if the database already exists (or does not already exist, respectively).

Additional info:

  • when testing different versions, ensure that you have used shift-F5 to ensure the browser reloads the JavaScript resources from the server
  • the issue appears to have been introduced between v0.10.3 and v0.11.1
@jonseymour
Copy link
Contributor Author

I bisected the commit that caused this issue down to 0cd440e. /cc @toddboom

@jonseymour
Copy link
Contributor Author

Fixed by #6194.

jonseymour added a commit to jonseymour/influxdb that referenced this issue Apr 4, 2016
)

A change to the admin UI prevented the success message being displayed
for empty results. This change restores the original behaviour for
this case.

Signed-off-by: Jon Seymour <jon@wildducktheories.com>
jonseymour added a commit to jonseymour/influxdb that referenced this issue Apr 4, 2016
)

A change to the admin UI prevented the success message being displayed
for empty results. This change restores the original behaviour for
this case.

Signed-off-by: Jon Seymour <jon@wildducktheories.com>
toddboom pushed a commit that referenced this issue Apr 4, 2016
A change to the admin UI prevented the success message being displayed
for empty results. This change restores the original behaviour for
this case.

Signed-off-by: Jon Seymour <jon@wildducktheories.com>
@toddboom
Copy link
Contributor

toddboom commented Apr 4, 2016

@jonseymour Thanks for taking care of this! I've merged your PR into master and 0.12, so future releases off of those branches will have this. I'll go ahead and merge it into the 0.11 branch, but we don't currently have any plans to cut another point release in the 0.11.x line.

@toddboom toddboom closed this as completed Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants