Add input for receiving papertrail webhooks #2038
Conversation
rossmcdonald
force-pushed
the
ross-papertrail-input
branch
from
4a0c9cd
to
9641507
Compare
|
|
||
| ## Events | ||
|
|
||
| See [here](http://help.papertrailapp.com/kb/how-it-works/web-hooks/#callback) for full documentation. |
There was a problem hiding this comment.
I prefer links without name here. You could make the full sentence clickable, such as [See the full documentation](http://help.papertrailapp.com/kb/how-it-works/web-hooks/#callback).
| Events from Papertrail come in two forms: | ||
|
|
||
| * The event-based callback (shown in the example | ||
| [here](http://help.papertrailapp.com/kb/how-it-works/web-hooks/#callback)): |
There was a problem hiding this comment.
Same here: shown in the exampleclickable
|
@danielnelson can you take a look at this |
| When an event is received, any point will look similar to: | ||
|
|
||
| ``` | ||
| papertrail,host=myserver.example.com,event=saved_search_name count=3 1453248892 |
There was a problem hiding this comment.
Count should be an integer and the timestamp in nanoseconds
|
|
||
| var payload Payload | ||
| // JSON payload is x-www-form-urlencoded, remove this string when unmarshaling | ||
| remove := "payload=" |
There was a problem hiding this comment.
Should do real unencoding in case the JSON has special escaped characters.
| type Count struct { | ||
| SourceName string `json:"source_name"` | ||
| SourceID int64 `json:"source_id"` | ||
| TimeSeries *map[int]int `json:"timeseries"` |
| payload := url.QueryEscape(sampleEventPayload) | ||
| resp := postWebhooks(pt, payload) | ||
| if resp.Code != http.StatusOK { | ||
| t.Errorf("POST new_item returned HTTP status code %v.\nExpected %v", resp.Code, http.StatusOK) |
There was a problem hiding this comment.
Remove newlines in error
| payload := url.QueryEscape(sampleCountPayload) | ||
| resp := postWebhooks(pt, payload) | ||
| if resp.Code != http.StatusOK { | ||
| t.Errorf("POST new_item returned HTTP status code %v.\nExpected %v", resp.Code, http.StatusOK) |
There was a problem hiding this comment.
Remove newlines in error
danielnelson
force-pushed
the
ross-papertrail-input
branch
from
9641507
to
2351e48
Compare
|
@francois2metz Would you like to take a second look at the updated code? |
| } | ||
|
|
||
| func (pt *PapertrailWebhook) eventHandler(w http.ResponseWriter, r *http.Request) { | ||
| if r.Method != "POST" { |
There was a problem hiding this comment.
I don't know if this check is really needed. This handle is already restricted to the POST method in the Register function.
|
Looks good 👍 , don't forget to update all the readme involved when adding a new webhook: the root README.me and plugins/inputs/webhooks/README.md. |
danielnelson
force-pushed
the
ross-papertrail-input
branch
from
2351e48
to
c5956b1
Compare
danielnelson
force-pushed
the
ross-papertrail-input
branch
from
ac89667
to
d8f24ff
Compare
Required for all PRs: