Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor process resource limits/usage #2617

Closed
phemmer opened this issue Apr 3, 2017 · 2 comments · Fixed by #3231
Closed

Monitor process resource limits/usage #2617

phemmer opened this issue Apr 3, 2017 · 2 comments · Fixed by #3231

Comments

@phemmer
Copy link
Contributor

phemmer commented Apr 3, 2017

Feature Request

Proposal:

Telegraf should provide process resource limits & usage.
Linux provides /proc/$pid/limits for indicating the resource limits of a process. At a minimum the "soft" values should be provided. Thought it might also be beneficial to provide the "hard" values.

Additionally many of the resources indicated in this file are not currently reported by telegraf's procstat input, such as stack size, locked memory, etc. These numbers should be provided.
And while we're at it, many of these missing numbers come from /proc/$pid/status. If we're going to add the ones corresponding to the values in /proc/$pid/limits, it might be a good idea to just add all of them (all the ones that make sense anyway, meaning not stuff like "Groups" or "TracerPid").

Current behavior:

Doesn't do the proposal.

Desired behavior:

Do the proposal.

Use case: [Why is this important (helps with prioritizing requests)]

Hitting these resource limits can cause applications to fail. Thus they should be monitored so that admins can be aware of resource usage, and take action to fix things before they fail.

@danielnelson
Copy link
Contributor

Sure, is everything available from gopsutil?

@phemmer
Copy link
Contributor Author

phemmer commented Apr 4, 2017

No. Looks like it'll need a PR to add some stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants