Add aerospike plugin support #300
Conversation
oldmantaiter
force-pushed
the
aerospike-plugin
branch
3 times, most recently
from
3243645
to
dc5162f
Compare
| ) | ||
|
|
||
| import ( | ||
| "github.com/influxdb/telegraf/plugins" |
There was a problem hiding this comment.
Just the way I do it, anything that needs a go get is in the second import statement. Looking around it seems like that clashes with the current style, so I will change it to conform with that.
|
Thanks @oldmantaiter!, just a couple things:
|
oldmantaiter
force-pushed
the
aerospike-plugin
branch
from
dc5162f
to
c8a96ac
Compare
|
@sparrc Definitely forgot about the README, will add one. I will work on adding more unittests (they are not my forté but I will give it a shot). |
oldmantaiter
force-pushed
the
aerospike-plugin
branch
8 times, most recently
from
05d70a5
to
84d060a
Compare
- Does not use the aerospike client, but sends the stats command using the aerospike required format - Queries available namespaces and gets stats for all of them
oldmantaiter
force-pushed
the
aerospike-plugin
branch
from
84d060a
to
e68ba1f
Compare
|
@sparrc Added README, and a few more tests. I believe I have covered most of the functions that are in there besides the ones that call the server directly/indirectly. Let me know what you think. |
|
awesome, thanks @oldmantaiter, will get this merged soon |
|
@sparrc Great! I do know that there are a lot of metrics that would get pushed because of this, I was thinking of adding some sort of globbing filter to match keys from the aerospike stats output. Also wanted to know if instead of doing this via the stdlibs if I should just include the aerospike client library as a dependency; I was not sure if this is something that is currently allowed or if it should be avoided as much as possible. |
using the aerospike required format