[1.6] Graphite protocol format changed

[PierreF]

The graphite format of some metric had changed. I'm unsure if that is wanted or not (I didn't see any note on the changelog).

The issue is for some number (I think uint value) which are now written on graphite in hexadecimal:

frigg.mem.free 0x287d8000 1523971560

Previously there were:

frigg.mem.free 757952512 1523971520

I've performed a git bisect and found that it's #3948 which introduced the issue.

Is it a regression or is it wanted ? :)

Relevant telegraf.conf:

$ cat telegraf.conf
[[outputs.graphite]]
  servers = ["localhost:1234"]
[[inputs.mem]]

System info:

Working Telegraf are any commit before b99cd14 (I've used the immediate parent c2108fc)

$ ./telegraf-good -version
Telegraf v1.6.0~c2108fcf (git: HEAD c2108fcf)

$ ./telegraf-bad -version
Telegraf v1.6.0~b99cd141 (git: HEAD b99cd141)

Steps to reproduce:

1. Configure telegraf.conf to write on graphite (cf the telegraf.conf above)
2. Run your graphite server (for testing nc -l 1234 is fine :))
3. Run telegraf

$ ./telegraf-bad -config ./telegraf.conf

Expected behavior:

Graphite output stay the same as previous release. i.e. output like:

frigg.mem.total 16522211328 1523971520
frigg.mem.available 7092830208 1523971520
frigg.mem.buffered 1878556672 1523971520
frigg.mem.wired 0 1523971520
frigg.mem.available_percent 42.92906117221648 1523971520
frigg.mem.used 9429381120 1523971520
frigg.mem.inactive 5394378752 1523971520
frigg.mem.slab 714162176 1523971520
frigg.mem.used_percent 57.07093882778352 1523971520
frigg.mem.free 757952512 1523971520
frigg.mem.cached 4904103936 1523971520
frigg.mem.active 8515653632 1523971520
frigg.mem.slab 714588160 1523971530
frigg.mem.used 9530183680 1523971530
frigg.mem.free 657797120 1523971530
frigg.mem.inactive 5462401024 1523971530
frigg.mem.active 8545935360 1523971530
frigg.mem.available 6992027648 1523971530
frigg.mem.buffered 1878593536 1523971530
frigg.mem.available_percent 42.318957851305846 1523971530
frigg.mem.wired 0 1523971530
frigg.mem.used_percent 57.681042148694154 1523971530
frigg.mem.total 16522211328 1523971530
frigg.mem.cached 4972773376 1523971530

Actual behavior:

Graphite output had changed and encode some number as hexadecimal number. i.e. output like:

frigg.mem.free 0x287d8000 1523971560
frigg.mem.used 0x234f7c000 1523971560
frigg.mem.wired 0x0 1523971560
frigg.mem.buffered 0x6ffb0000 1523971560
frigg.mem.slab 0x2aa2d000 1523971560
frigg.mem.available_percent 42.63124844592231 1523971560
frigg.mem.inactive 0x14841e000 1523971560
frigg.mem.total 0x3d8ccf000 1523971560
frigg.mem.available 0x1a3d53000 1523971560
frigg.mem.used_percent 57.36875155407769 1523971560
frigg.mem.cached 0x12b18b000 1523971560
frigg.mem.active 0x1f96b5000 1523971560
frigg.mem.available_percent 42.68950699139732 1523971570
frigg.mem.slab 0x2aa56000 1523971570
frigg.mem.total 0x3d8ccf000 1523971570
frigg.mem.free 0x28fa2000 1523971570
frigg.mem.buffered 0x6ffd1000 1523971570
frigg.mem.active 0x1fc505000 1523971570
frigg.mem.inactive 0x144f15000 1523971570
frigg.mem.used_percent 57.31049300860268 1523971570
frigg.mem.available 0x1a4681000 1523971570
frigg.mem.cached 0x127dbd000 1523971570
frigg.mem.used 0x23464e000 1523971570
frigg.mem.wired 0x0 1523971570

[danielnelson]

No this is definitely a bug, I'll fix it.