Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full flush interval to be used for flushing with flush_jitter. #4232

Closed
danielnelson opened this issue Jun 5, 2018 · 0 comments · Fixed by #7390
Closed

Allow full flush interval to be used for flushing with flush_jitter. #4232

danielnelson opened this issue Jun 5, 2018 · 0 comments · Fixed by #7390
Labels
area/agent feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@danielnelson
Copy link
Contributor

Feature Request

When using a flush_interval and flush_jitter of the same duration and the
random sleep jitter is close to the length of the interval, the output may
have no time available before the "Skipping a scheduled flush" warning is
emitted.

This forces the flush_jitter to be smaller than the interval making it
impossible to take advantage of the full interval period.

Current behavior:

If jitter is the same as interval and the flush takes "2s" you can expect
warnings if there is a high jitter followed by a low jitter:

[agent]
  flush_interval = "10s"
  flush_jitter = "10s"

If the jitter is half the interval then no warnings, but all writes take place
in the first half of the flush interval:

[agent]
  flush_interval = "10s"
  flush_jitter = "5s"

Desired behavior:

If a flush starts at the end of the period, there shouldn't be a warning
unless it exceeds a certain period of time.

Use case: [Why is this important (helps with prioritizing requests)]

Balancing connections to InfluxDB over the full flush interval without uneven
writes.

@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label Jun 5, 2018
@russorat russorat added this to the 1.10 milestone Oct 22, 2018
@danielnelson danielnelson modified the milestones: 1.10.0, 1.11.0 Feb 4, 2019
@danielnelson danielnelson modified the milestones: 1.11.0, 1.12.0 May 15, 2019
@russorat russorat modified the milestones: 1.12.0, 1.13.0 Aug 5, 2019
@danielnelson danielnelson modified the milestones: 1.13.0, 1.14.0 Dec 2, 2019
@sjwang90 sjwang90 modified the milestones: 1.14.0, 1.15.0 Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants