Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couchbase security problem: credential leakage like #1680 #5215

Closed
babs opened this issue Jan 2, 2019 · 0 comments
Closed

Couchbase security problem: credential leakage like #1680 #5215

babs opened this issue Jan 2, 2019 · 0 comments
Assignees
Milestone

Comments

@babs
Copy link

babs commented Jan 2, 2019

Security problem related to #1680

Relevant telegraf.conf:

[[inputs.couchbase]]
servers = ["http://admin:xxxxx@localhost:8091"]

System info:

Telegraf v1.7.0 (git: release-1.7 f4d22dd)

Expected behavior:

While node cluster tag has been properly sanitized, bucket stats hasn't and password is still show in the tag

I think it's a matter of

Porting https://github.com/DanKans/telegraf/blob/ab1c11b06d7b1a0542d1d8b2106e6af825b866cc/plugins/inputs/couchbase/couchbase.go#L81 change to https://github.com/DanKans/telegraf/blob/ab1c11b06d7b1a0542d1d8b2106e6af825b866cc/plugins/inputs/couchbase/couchbase.go#L89

tags := map[string]string{"cluster": addr, "bucket": bucketName} to tags := map[string]string{"cluster": regexpURI.ReplaceAllString(addr, "${1}"), "bucket": bucketName}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants