Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent discards the whole batch of metrics in case of a serialization issue in a single metric #5858

Closed
ayansen opened this issue May 15, 2019 · 0 comments · Fixed by #5943
Closed
Assignees
Labels
bug unexpected problem or unintended behavior
Milestone

Comments

@ayansen
Copy link

ayansen commented May 15, 2019

Relevant telegraf.conf:

[global_tags]  
  interval = "30"
  m_application = "mt-relay"

[agent]
  interval = "30s"
  flush_interval = "30s"
  metric_buffer_limit = 10000 
  debug = true 
 
[[outputs.http]]
  url = "http://localhost:1337/influx/metric"
  data_format = "influx"

[[inputs.prometheus]]
  monitor_kubernetes_pods = true
  urls = ["http://prometheus-server/metrics"]

System info:

Telegraf 1.9.5
Ubuntu 16.04 LTS

Steps to reproduce:

  1. ... expose a prometheus metric who which has gauge metric with an invalid value

Expected behavior:

The metric should be discarded by the agent

Actual behavior:

The whole batch of metrics get discarded due to a serialization failure in a single metric

Additional info:

2019-05-15T06:49:00Z E! [agent] Error writing to output [http]: "kafka_consumer_fetch_latency_max,address=10.1.206.168,app=enriched-order-events-producer,client_id=enriched-order-events-producer-84126f3b-093b-41d3-bece-5b1cf8deebe1-StreamThread-1-consumer,host=mt-relay-5b86dd7bcd-k9g6n,interval=30,m_application=enriched-order-events-producer,m_region=us-east-1,namespace=neurons,pod-template-hash=732570943,pod_name=enriched-order-events-producer-c769c4f87-x699z,prometheus.io/path=/metrics,prometheus.io/port=8080,prometheus.io/scrape=true,url=http://10.1.206.168:8080/metrics": no serializable fields
2019-05-15T06:49:00Z D! [serializers.influx] could not serialize field "gauge": is Inf; discarding field

Code line : https://github.com/influxdata/telegraf/blob/master/agent/agent.go#L543

@ayansen ayansen changed the title Agent discards the whole batch of metrics in case of a serialization issue in a single metric agent discards the whole batch of metrics in case of a serialization issue in a single metric May 15, 2019
@danielnelson danielnelson added this to the 1.11.0 milestone May 15, 2019
@danielnelson danielnelson added the bug unexpected problem or unintended behavior label May 15, 2019
@danielnelson danielnelson self-assigned this May 15, 2019
@danielnelson danielnelson modified the milestones: 1.11.0, 1.12.0 Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants