Fix incorrect Azure SQL DB server properties #7715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sql_server_properties measure had a few incorrect values for Azure SQL DB a. Number of DB's online/offline/suspect is irrelevant for a single DB and was counting master had incorrect values of 2 b. Space usage (Max/unallocated) was also set to NULL prior c. Given all the 3 parts of this collector required adhoc queries, eliminated the unnecessarily table variable to simplify query
|
@Trovalo can you take quick look. |
danielnelson
added
area/sqlserver
feat
|
I've tested it on on-prem and the output is the same. |
Trovalo
approved these changes
Jun 24, 2020
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sql_server_properties measure had a few incorrect values for Azure SQL DB
a. Number of DB's online/offline/suspect is irrelevant for a single DB and was counting master had incorrect values of 2
b. Space usage (Max/unallocated) was also set to NULL prior
c. Given all the 3 parts of this collector required adhoc queries, eliminated the unnecessarily table variable to simplify query
Required for all PRs: