Changes init script exit code to conform to lsb standards #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuder
changed the title
| @@ -148,7 +148,7 @@ case $1 in | |||
| fi | |||
There was a problem hiding this comment.
Shouldn't we return 3 on the line above this one, if the call to pidofproc failes
There was a problem hiding this comment.
@jvshahid Isn't the one above (line 146) only exectued if the pid file exists, but the proceess doesn't? If so then exit code 1 would be the correct I think.
lsb status codes
| exit code | condition |
|---|---|
| 0 | program is running or service is OK |
| 1 | program is dead and /var/run pid file exists |
| 2 | program is dead and /var/lock lock file exists |
| 3 | program is not running |
| 4 | program or service status is unknown |
| 5-99 | reserved for future LSB use |
| 100-149 | reserved for distribution use |
| 150-199 | reserved for application use |
| 200-254 | reserved |
|
Cool, lgtm |
jvshahid
added a commit
that referenced
this pull request
Oct 10, 2014
Changes init script exit code to conform to lsb standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #1016