Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error message in database EncodeFields #2700

Closed
greglook opened this issue May 29, 2015 · 0 comments
Closed

Incorrect error message in database EncodeFields #2700

greglook opened this issue May 29, 2015 · 0 comments
Assignees
@jwilder
Labels
area/error handling
Milestone
0.9.0

Comments

@greglook
Copy link

I believe this line in database.go is wrong, because we're getting some very confusing error messages in production:

{"error":"field \"clock-skew-timestamp\" is type string, mapped as type string"}

It looks like the first type given in the error message is taking the type of the field key, rather than the value. The other location this error message is used seems to correctly use the value for type testing.

This is with version 0.9.0-rc29, but it looks like the error is still present in master.
@beckettsean beckettsean added this to the 0.9.0 milestone Jun 9, 2015
jwilder added a commit that referenced this issue Jun 10, 2015
@jwilder
Fix wrong value used for incorrect type error message
0d9a2a5 
Would result in saying that the field type was always a string which
is incorrect.  The field key is a string but the value may not be.

Fixes #2700
@jwilder jwilder self-assigned this Jun 10, 2015
@jwilder jwilder mentioned this issue Jun 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwilder jwilder

Labels
area/error handling
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
3 participants
@jwilder @greglook @beckettsean