Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show retention policies should be consistent with other queries #2761

Closed
beckettsean opened this issue Jun 3, 2015 · 6 comments
Closed

show retention policies should be consistent with other queries #2761

beckettsean opened this issue Jun 3, 2015 · 6 comments
Assignees
Milestone

Comments

@beckettsean
Copy link
Contributor

Right now the syntax is SHOW RETENTION POLICIES <db-name>, but DROP RETENTION POLICY <rp-name> ON <db-name>. For users it's GRANT/REVOKE <privilege> ON <db-name>

I think SHOW RETENTION POLICIES ON <db-name> is more congruent with the other statements, and I find myself typing ON every time and then removing it when the parser complains.

@corylanou
Copy link
Contributor

We should support either way, but certainly +1 for the consistent manner.

@EvanDarwin
Copy link

+1

@beckettsean beckettsean added this to the 0.9.2 milestone Jun 9, 2015
@dgnorton
Copy link
Contributor

+10
@corylanou support both for backwards compatibility?

@corylanou
Copy link
Contributor

@dgnorton If it's not too hard to support both, that's fine. Many languages support variant commands. I don't think that we really have to if we don't want to, so for me, it's a matter of what is easiest.

I support 2 versions of select count(distinct(foo)) and select count(distinct foo) so it isn't like we haven't already broken the there is only one way rule :-).

@dgnorton
Copy link
Contributor

@corylanou We support 2 versions of count distinct on purpose. I think leaving ON out of SHOW RETENTION POLICIES was unintentional. :)

@gunnaraasen
Copy link
Member

Fixed by #3345

srinisakh pushed a commit to srinisakh/ansible-monasca-schema that referenced this issue Oct 9, 2015
The the code to use correct SHOW retention command starting with 0.9.2
influxdata/influxdb#2761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants