Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow wildcards with fields in select statements #3580

Merged
merged 2 commits into from
Aug 6, 2015

Conversation

corylanou
Copy link
Contributor

The following queries should not be valid:

select *, foo from bar
select foo, * from bar
select *, * from bar

@DanielMorsing
Copy link
Contributor

I think there is a place for this. Consider select *, foo * 20 from bar, where the users wants to see all the fields and some derived value from it.

@corylanou
Copy link
Contributor Author

@DanielMorsing yes, I agree, there are several good reasons. We are putting this in here because we don't currently support it. Once the query engine has support for it, we will remove this restriction.

@DanielMorsing
Copy link
Contributor

+1 if a TODO is added that states that this is temporary in validateWildcard

@corylanou
Copy link
Contributor Author

@DanielMorsing I opened an issue, which is more likely to get noticed than a TODO in the code.

#3582

corylanou added a commit that referenced this pull request Aug 6, 2015
Do not allow wildcards with fields in select statements
@corylanou corylanou merged commit f6b2af2 into master Aug 6, 2015
@corylanou corylanou deleted the enforce-single-select-wildcard branch August 6, 2015 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants