Convert meta shard owners to objects #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit converts meta.ShardInfo.OwnerIDs from a slice of ids to a slice of objects. This is to support adding statuses for a shard for a given node. For example, a node may have a shard assigned to it but it is currently copying the shard and is not ready to serve data for it. The old `OwnerIDs` is marked as deprecated, however, the code still supports loading from older protobuf-encoded data.
|
+1 |
benbjohnson
added a commit
that referenced
this pull request
Sep 1, 2015
Convert meta shard owners to objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit converts meta.ShardInfo.OwnerIDs from a slice of ids to a slice of objects. This is to support adding statuses for a shard for a given node. For example, a node may have a shard assigned to it but it is currently copying the shard and is not ready to serve data for it.
The old
OwnerIDsis marked as deprecated, however, the code still supports loading from older protobuf encoded data.