Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing defer/recover/panic idiom in HTTPD service #4124

Closed
corylanou opened this issue Sep 16, 2015 · 0 comments · Fixed by #4147
Closed

Missing defer/recover/panic idiom in HTTPD service #4124

corylanou opened this issue Sep 16, 2015 · 0 comments · Fixed by #4147
Assignees
@corylanou
Milestone
0.9.5

Comments

@corylanou
Copy link
Contributor

We are missing this idiom:

 defer func() {
        if r := recover(); r != nil {
            fmt.Println("Recovered in f", r)
        }
    }()

In the HTTPD service recovery handler:

https://github.com/influxdb/influxdb/blob/master/services/httpd/handler.go#L800

This is allowing queries to panic and bring down the service.
@corylanou corylanou self-assigned this Sep 16, 2015
@corylanou corylanou added this to the 0.9.5 milestone Sep 16, 2015
corylanou added a commit that referenced this issue Sep 17, 2015
@corylanou
Mising defer in httpd recovery. fixes #4124
38cb7b4
@corylanou corylanou mentioned this issue Sep 17, 2015
Merged
corylanou added a commit that referenced this issue Sep 17, 2015
@corylanou
Merge pull request #4147 from influxdb/httpd-recovery
83d2df1 
Missing defer in httpd recovery.  fixes #4124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corylanou corylanou

Labels
None yet
Projects
None yet
Milestone
0.9.5
Development

Successfully merging a pull request may close this issue.

Missing defer in httpd recovery. fixes #4124 influxdata/influxdb
1 participant
@corylanou