Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.9.4.1] Panic due no protection on value containing '-' #4272

Closed
JulienChampseix opened this issue Sep 29, 2015 · 7 comments
Closed

[0.9.4.1] Panic due no protection on value containing '-' #4272

JulienChampseix opened this issue Sep 29, 2015 · 7 comments
Assignees
@otoolep
Labels
area/writes
Milestone
0.9.5

Comments

@JulienChampseix
Copy link

Hi,

When i sending an malformed query write the influxdb server crashed (due non protection for this type of value).
Command curl :
curl -i -XPOST 'http://localhost:8086/write?db=brain.applications&u=test&p=test' --data-binary 'temperature,host=server02 value=-0.67,value2=-'

The value1 is well formatted but value2 only containing '-' which create a panic on the influxdb server (= crash)

Would be great to have a protection for something like that.

See bellow the stack crash :

panic: unable to parse number value '-': strconv.ParseFloat: parsing "-": invalid syntax

goroutine 133125 [running]:
github.com/influxdb/influxdb/tsdb.newFieldsFromBinary(0xc820091244, 0x4d, 0x1bc, 0xc8573766c0)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/points.go:1282 +0x6a2
github.com/influxdb/influxdb/tsdb.(*point).unmarshalBinary(0xc82fac6ab0, 0xc856066ba0)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/points.go:1170 +0x40
github.com/influxdb/influxdb/tsdb.(*point).Fields(0xc82fac6ab0, 0xc836583500)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/points.go:1115 +0x3a
github.com/influxdb/influxdb/tsdb.(*Shard).validateSeriesAndFields(0xc836580fc0, 0xc8573765b0, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/shard.go:403 +0x670
github.com/influxdb/influxdb/tsdb.(*Shard).WritePoints(0xc836580fc0, 0xc8573765b0, 0x1, 0x1, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/shard.go:197 +0xa2
github.com/influxdb/influxdb/tsdb.(*Store).WriteToShard(0xc820182000, 0x13, 0xc8573765b0, 0x1, 0x1, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/store.go:339 +0xf7
github.com/influxdb/influxdb/cluster.(*PointsWriter).writeToShard.func1(0xc82012ed80, 0xc8258e54ff, 0x12, 0xc820288b20, 0x7, 0xc85838a360, 0x1, 0x13, 0x1, 0xc8573765b0, ...)
    /tmp/build/src/github.com/influxdb/influxdb/cluster/points_writer.go:267 +0x108
created by github.com/influxdb/influxdb/cluster.(*PointsWriter).writeToShard
    /tmp/build/src/github.com/influxdb/influxdb/cluster/points_writer.go:299 +0x1c5

goroutine 1 [chan receive, 1669 minutes]:
main.(*Main).Run(0xc8225abf10, 0xc82000a0b0, 0x4, 0x4, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/main.go:91 +0xa16
main.main()
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/main.go:42 +0x29b

goroutine 17 [syscall, 1669 minutes, locked to thread]:
runtime.goexit()
    /home/philip/.gvm/gos/go1.5/src/runtime/asm_amd64.s:1696 +0x1

goroutine 5 [syscall, 1669 minutes]:
os/signal.loop()
    /home/philip/.gvm/gos/go1.5/src/os/signal/signal_unix.go:22 +0x18
created by os/signal.init.1
    /home/philip/.gvm/gos/go1.5/src/os/signal/signal_unix.go:28 +0x37

goroutine 18 [IO wait, 1669 minutes]:
net.runtime_pollWait(0x7f78e6016040, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc820128300, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc820128300, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).accept(0xc8201282a0, 0x0, 0x7f78e805c9e0, 0xc858eb4920)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:408 +0x27c
net.(*TCPListener).AcceptTCP(0xc820126068, 0xc83dd9deb8, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/tcpsock_posix.go:254 +0x4d
net.(*TCPListener).Accept(0xc820126068, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/tcpsock_posix.go:264 +0x3d
github.com/influxdb/influxdb/tcp.(*Mux).Serve(0xc820121040, 0x7f78e60150c0, 0xc820126068, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tcp/mux.go:48 +0x4b
created by github.com/influxdb/influxdb/cmd/influxd/run.(*Server).Open.func1
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/run/server.go:345 +0xae9

goroutine 19 [chan receive, 1669 minutes]:
github.com/influxdb/influxdb/tcp.(*listener).Accept(0xc820126070, 0x0, 0x0, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tcp/mux.go:129 +0x6f
github.com/influxdb/influxdb/meta.(*raftLayer).Accept(0xc82017f020, 0x0, 0x0, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/meta/store.go:2059 +0x51
github.com/hashicorp/raft.(*NetworkTransport).listen(0xc820128310)
    /tmp/build/src/github.com/hashicorp/raft/net_transport.go:346 +0x79
created by github.com/hashicorp/raft.NewNetworkTransport
    /tmp/build/src/github.com/hashicorp/raft/net_transport.go:138 +0x284

goroutine 20 [select]:
github.com/hashicorp/raft.(*Raft).leaderLoop(0xc820198000)
    /tmp/build/src/github.com/hashicorp/raft/raft.go:849 +0xcce
github.com/hashicorp/raft.(*Raft).runLeader(0xc820198000)
    /tmp/build/src/github.com/hashicorp/raft/raft.go:821 +0x936
github.com/hashicorp/raft.(*Raft).run(0xc820198000)
    /tmp/build/src/github.com/hashicorp/raft/raft.go:602 +0xbb
github.com/hashicorp/raft.(*Raft).(github.com/hashicorp/raft.run)-fm()
    /tmp/build/src/github.com/hashicorp/raft/raft.go:252 +0x20
github.com/hashicorp/raft.(*raftState).goFunc.func1(0xc820198000, 0xc820190450)
    /tmp/build/src/github.com/hashicorp/raft/state.go:152 +0x44
created by github.com/hashicorp/raft.(*raftState).goFunc
    /tmp/build/src/github.com/hashicorp/raft/state.go:153 +0x4d

goroutine 21 [select, 1317 minutes]:
github.com/hashicorp/raft.(*Raft).runFSM(0xc820198000)
    /tmp/build/src/github.com/hashicorp/raft/raft.go:509 +0x10eb
github.com/hashicorp/raft.(*Raft).(github.com/hashicorp/raft.runFSM)-fm()
    /tmp/build/src/github.com/hashicorp/raft/raft.go:253 +0x20
github.com/hashicorp/raft.(*raftState).goFunc.func1(0xc820198000, 0xc820190460)
    /tmp/build/src/github.com/hashicorp/raft/state.go:152 +0x44
created by github.com/hashicorp/raft.(*raftState).goFunc
    /tmp/build/src/github.com/hashicorp/raft/state.go:153 +0x4d

goroutine 22 [select, 2 minutes]:
github.com/hashicorp/raft.(*Raft).runSnapshots(0xc820198000)
    /tmp/build/src/github.com/hashicorp/raft/raft.go:1636 +0x493
github.com/hashicorp/raft.(*Raft).(github.com/hashicorp/raft.runSnapshots)-fm()
    /tmp/build/src/github.com/hashicorp/raft/raft.go:254 +0x20
github.com/hashicorp/raft.(*raftState).goFunc.func1(0xc820198000, 0xc820190470)
    /tmp/build/src/github.com/hashicorp/raft/state.go:152 +0x44
created by github.com/hashicorp/raft.(*raftState).goFunc
    /tmp/build/src/github.com/hashicorp/raft/state.go:153 +0x4d

goroutine 23 [select, 1669 minutes]:
github.com/influxdb/influxdb/meta.(*localRaft).logLeaderChanges(0xc82012ccd0)
    /tmp/build/src/github.com/influxdb/influxdb/meta/state.go:187 +0x4f5
created by github.com/influxdb/influxdb/meta.(*localRaft).open
    /tmp/build/src/github.com/influxdb/influxdb/meta/state.go:177 +0x1344

goroutine 24 [chan receive, 1669 minutes]:
github.com/influxdb/influxdb/tcp.(*listener).Accept(0xc820126078, 0x0, 0x0, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tcp/mux.go:129 +0x6f
github.com/influxdb/influxdb/meta.(*Store).serveExecListener(0xc82014e140)
    /tmp/build/src/github.com/influxdb/influxdb/meta/store.go:622 +0xa2
created by github.com/influxdb/influxdb/meta.(*Store).Open
    /tmp/build/src/github.com/influxdb/influxdb/meta/store.go:239 +0x364

goroutine 25 [chan receive, 1669 minutes]:
github.com/influxdb/influxdb/tcp.(*listener).Accept(0xc820126080, 0x0, 0x0, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tcp/mux.go:129 +0x6f
github.com/influxdb/influxdb/meta.(*Store).serveRPCListener(0xc82014e140)
    /tmp/build/src/github.com/influxdb/influxdb/meta/store.go:726 +0xa2
created by github.com/influxdb/influxdb/meta.(*Store).Open
    /tmp/build/src/github.com/influxdb/influxdb/meta/store.go:242 +0x3b6

goroutine 8 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e61c0, 0xc820376660)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 35 [select, 1669 minutes]:
github.com/influxdb/influxdb/cmd/influxd/run.(*Server).monitorErrorChan(0xc820151560, 0xc820122480)
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/run/server.go:491 +0x145
created by github.com/influxdb/influxdb/cmd/influxd/run.(*Server).Open.func1
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/run/server.go:351 +0xc67

goroutine 37 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e6000, 0xc8203beb40)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 38 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e60e0, 0xc820501a40)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 9 [runnable]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e62a0, 0xc82023c300)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 75398 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e67e0, 0xc846839380)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 563 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e6380, 0xc82029b380)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 559 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e6460, 0xc82022a840)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 560 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc8202e6540, 0xc82221ec60)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 561 [select]:
github.com/influxdb/influxdb/services/hh.(*Service).retryWrites(0xc820132120)
    /tmp/build/src/github.com/influxdb/influxdb/services/hh/service.go:103 +0x314
created by github.com/influxdb/influxdb/services/hh.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/hh/service.go:67 +0x210

goroutine 1906 [select, 50 minutes]:
github.com/influxdb/influxdb/services/hh.(*Service).expireWrites(0xc820132120)
    /tmp/build/src/github.com/influxdb/influxdb/services/hh/service.go:121 +0x2d1
created by github.com/influxdb/influxdb/services/hh.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/hh/service.go:68 +0x232

goroutine 1907 [chan receive, 1669 minutes]:
github.com/influxdb/influxdb/tcp.(*listener).Accept(0xc820126088, 0x0, 0x0, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tcp/mux.go:129 +0x6f
github.com/influxdb/influxdb/cluster.(*Service).serve(0xc8201281c0)
    /tmp/build/src/github.com/influxdb/influxdb/cluster/service.go:84 +0xdb
created by github.com/influxdb/influxdb/cluster.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/cluster/service.go:61 +0x135

goroutine 1908 [select, 10 minutes]:
github.com/influxdb/influxdb/services/precreator.(*Service).runPrecreation(0xc820120c40)
    /tmp/build/src/github.com/influxdb/influxdb/services/precreator/service.go:75 +0x44f
created by github.com/influxdb/influxdb/services/precreator.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/precreator/service.go:53 +0x21f

goroutine 1909 [chan receive, 1669 minutes]:
github.com/influxdb/influxdb/tcp.(*listener).Accept(0xc820126090, 0x0, 0x0, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tcp/mux.go:129 +0x6f
github.com/influxdb/influxdb/services/snapshotter.(*Service).serve(0xc82012c640)
    /tmp/build/src/github.com/influxdb/influxdb/services/snapshotter/service.go:75 +0xa9
created by github.com/influxdb/influxdb/services/snapshotter.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/snapshotter/service.go:48 +0x130

goroutine 1910 [chan receive, 1669 minutes]:
github.com/influxdb/influxdb/tcp.(*listener).Accept(0xc820126098, 0x0, 0x0, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/tcp/mux.go:129 +0x6f
github.com/influxdb/influxdb/services/copier.(*Service).serve(0xc820120cc0)
    /tmp/build/src/github.com/influxdb/influxdb/services/copier/service.go:78 +0xa9
created by github.com/influxdb/influxdb/services/copier.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/copier/service.go:51 +0x130

goroutine 1911 [IO wait, 12 minutes]:
net.runtime_pollWait(0x7f78e4fa1b80, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc822208290, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc822208290, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).accept(0xc822208230, 0x0, 0x7f78e805c9e0, 0xc82034af60)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:408 +0x27c
net.(*TCPListener).AcceptTCP(0xc82065a208, 0xc8222a0d88, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/tcpsock_posix.go:254 +0x4d
net.(*TCPListener).Accept(0xc82065a208, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/tcpsock_posix.go:264 +0x3d
net/http.(*Server).Serve(0xc8222c4120, 0x7f78e60150c0, 0xc82065a208, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1887 +0xb3
net/http.Serve(0x7f78e60150c0, 0xc82065a208, 0x7f78e4f6d118, 0xc8222c0120, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1765 +0x85
github.com/influxdb/influxdb/services/admin.(*Service).serve(0xc82012c730)
    /tmp/build/src/github.com/influxdb/influxdb/services/admin/service.go:107 +0x12f
created by github.com/influxdb/influxdb/services/admin.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/admin/service.go:70 +0x491

goroutine 1912 [select]:
github.com/influxdb/influxdb/services/continuous_querier.(*Service).backgroundLoop(0xc820132240)
    /tmp/build/src/github.com/influxdb/influxdb/services/continuous_querier/service.go:192 +0x565
created by github.com/influxdb/influxdb/services/continuous_querier.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/continuous_querier/service.go:126 +0x2a4

goroutine 1913 [IO wait, 1 minutes]:
net.runtime_pollWait(0x7f78e4fa1940, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc822208300, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc822208300, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).accept(0xc8222082a0, 0x0, 0x7f78e805c9e0, 0xc8571a4120)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:408 +0x27c
net.(*TCPListener).AcceptTCP(0xc82065a210, 0xc8222fbdc0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/tcpsock_posix.go:254 +0x4d
net.(*TCPListener).Accept(0xc82065a210, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/tcpsock_posix.go:264 +0x3d
net/http.(*Server).Serve(0xc821701d40, 0x7f78e60150c0, 0xc82065a210, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1887 +0xb3
net/http.Serve(0x7f78e60150c0, 0xc82065a210, 0x7f78e4fa2600, 0xc82012ef00, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1765 +0x85
github.com/influxdb/influxdb/services/httpd.(*Service).serve(0xc820122900)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/service.go:133 +0x6e
created by github.com/influxdb/influxdb/services/httpd.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/service.go:101 +0x6ca

goroutine 1914 [select, 20 minutes]:
github.com/influxdb/influxdb/services/retention.(*Service).deleteShardGroups(0xc82012c8c0)
    /tmp/build/src/github.com/influxdb/influxdb/services/retention/service.go:69 +0x351
created by github.com/influxdb/influxdb/services/retention.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/retention/service.go:45 +0x1b4

goroutine 1915 [select, 20 minutes]:
github.com/influxdb/influxdb/services/retention.(*Service).deleteShards(0xc82012c8c0)
    /tmp/build/src/github.com/influxdb/influxdb/services/retention/service.go:102 +0x7a0
created by github.com/influxdb/influxdb/services/retention.(*Service).Open
    /tmp/build/src/github.com/influxdb/influxdb/services/retention/service.go:46 +0x1d9

goroutine 1916 [chan receive, 230 minutes]:
github.com/influxdb/influxdb/cmd/influxd/run.(*Server).startServerReporting(0xc820151560)
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/run/server.go:442 +0x1eb
created by github.com/influxdb/influxdb/cmd/influxd/run.(*Server).Open.func1
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/run/server.go:378 +0x1265

goroutine 1917 [select, 1669 minutes]:
github.com/influxdb/influxdb/cmd/influxd/run.(*Command).monitorServerErrors(0xc82012e000)
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/run/command.go:138 +0x2c5
created by github.com/influxdb/influxdb/cmd/influxd/run.(*Command).Run
    /tmp/build/src/github.com/influxdb/influxdb/cmd/influxd/run/command.go:120 +0xeeb

goroutine 1918 [select, 1669 minutes, locked to thread]:
runtime.gopark(0xd1af00, 0xc821fd6728, 0xbd6600, 0x6, 0x18, 0x2)
    /home/philip/.gvm/gos/go1.5/src/runtime/proc.go:185 +0x163
runtime.selectgoImpl(0xc821fd6728, 0x0, 0x18)
    /home/philip/.gvm/gos/go1.5/src/runtime/select.go:392 +0xa64
runtime.selectgo(0xc821fd6728)
    /home/philip/.gvm/gos/go1.5/src/runtime/select.go:212 +0x12
runtime.ensureSigM.func1()
    /home/philip/.gvm/gos/go1.5/src/runtime/signal1_unix.go:227 +0x353
runtime.goexit()
    /home/philip/.gvm/gos/go1.5/src/runtime/asm_amd64.s:1696 +0x1

goroutine 57388 [IO wait]:
net.runtime_pollWait(0x7f78e46edcc0, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc857ad40d0, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc857ad40d0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).Read(0xc857ad4070, 0xc8592e9000, 0x1000, 0x1000, 0x0, 0x7f78e8058050, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:232 +0x23a
net.(*conn).Read(0xc84dabe028, 0xc8592e9000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/net.go:172 +0xe4
net/http.(*liveSwitchReader).Read(0xc8200dc308, 0xc8592e9000, 0x1000, 0x1000, 0xc820730000, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:219 +0xa4
io.(*LimitedReader).Read(0xc8571a4560, 0xc8592e9000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/io/io.go:427 +0xbd
bufio.(*Reader).fill(0xc857e803c0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:97 +0x1e9
bufio.(*Reader).Peek(0xc857e803c0, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:132 +0xcc
net/http.(*conn).readRequest(0xc8200dc2c0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:629 +0x2bb
net/http.(*conn).serve(0xc8200dc2c0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1319 +0x727
created by net/http.(*Server).Serve
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1910 +0x3f6

goroutine 57387 [IO wait]:
net.runtime_pollWait(0x7f78e4f7a040, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc857ad4060, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc857ad4060, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).Read(0xc857ad4000, 0xc8592ef000, 0x1000, 0x1000, 0x0, 0x7f78e8058050, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:232 +0x23a
net.(*conn).Read(0xc84dabe010, 0xc8592ef000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/net.go:172 +0xe4
net/http.(*liveSwitchReader).Read(0xc8200dc258, 0xc8592ef000, 0x1000, 0x1000, 0xc8592c5000, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:219 +0xa4
io.(*LimitedReader).Read(0xc8571a41c0, 0xc8592ef000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/io/io.go:427 +0xbd
bufio.(*Reader).fill(0xc857e80180)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:97 +0x1e9
bufio.(*Reader).Peek(0xc857e80180, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:132 +0xcc
net/http.(*conn).readRequest(0xc8200dc210, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:629 +0x2bb
net/http.(*conn).serve(0xc8200dc210)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1319 +0x727
created by net/http.(*Server).Serve
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1910 +0x3f6

goroutine 28578 [IO wait]:
net.runtime_pollWait(0x7f78e42dd180, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc83c1054f0, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc83c1054f0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).Read(0xc83c105490, 0xc83c6e8000, 0x1000, 0x1000, 0x0, 0x7f78e8058050, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:232 +0x23a
net.(*conn).Read(0xc820136f78, 0xc83c6e8000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/net.go:172 +0xe4
net/http.(*liveSwitchReader).Read(0xc8200dc0f8, 0xc83c6e8000, 0x1000, 0x1000, 0xc83c6e9000, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:219 +0xa4
io.(*LimitedReader).Read(0xc83c1cf160, 0xc83c6e8000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/io/io.go:427 +0xbd
bufio.(*Reader).fill(0xc83c67c3c0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:97 +0x1e9
bufio.(*Reader).Peek(0xc83c67c3c0, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:132 +0xcc
net/http.(*conn).readRequest(0xc8200dc0b0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:629 +0x2bb
net/http.(*conn).serve(0xc8200dc0b0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1319 +0x727
created by net/http.(*Server).Serve
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1910 +0x3f6

goroutine 132621 [select]:
github.com/influxdb/influxdb/cluster.(*PointsWriter).WritePoints(0xc82012ed80, 0xc8592bf000, 0x0, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/cluster/points_writer.go:230 +0x586
github.com/influxdb/influxdb/services/httpd.(*Handler).serveWriteLine(0xc82012ef00, 0x7f78e449ee58, 0xc856066b00, 0xc8202e6620, 0xc820091200, 0x92, 0x200, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:524 +0xeb0
github.com/influxdb/influxdb/services/httpd.(*Handler).serveWrite(0xc82012ef00, 0x7f78e449ee58, 0xc856066b00, 0xc8202e6620, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:376 +0x79c
github.com/influxdb/influxdb/services/httpd.(*Handler).(github.com/influxdb/influxdb/services/httpd.serveWrite)-fm(0x7f78e449ee58, 0xc856066b00, 0xc8202e6620, 0x0)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:106 +0x48
github.com/influxdb/influxdb/services/httpd.authenticate.func1(0x7f78e449ee58, 0xc856066b00, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:673 +0x70
net/http.HandlerFunc.ServeHTTP(0xc820180c60, 0x7f78e449ee58, 0xc856066b00, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1422 +0x3a
github.com/influxdb/influxdb/services/httpd.gzipFilter.func1(0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:734 +0x2af
net/http.HandlerFunc.ServeHTTP(0xc820180c80, 0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1422 +0x3a
github.com/influxdb/influxdb/services/httpd.versionHeader.func1(0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:743 +0xc0
net/http.HandlerFunc.ServeHTTP(0xc820180ca0, 0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1422 +0x3a
github.com/influxdb/influxdb/services/httpd.cors.func1(0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:776 +0x328
net/http.HandlerFunc.ServeHTTP(0xc820180cc0, 0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1422 +0x3a
github.com/influxdb/influxdb/services/httpd.requestID.func1(0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:786 +0x15d
net/http.HandlerFunc.ServeHTTP(0xc820180ce0, 0x7f78e449ed80, 0xc856066a80, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1422 +0x3a
github.com/influxdb/influxdb/services/httpd.logging.func1(0x7f78e449ed80, 0xc856066a60, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:794 +0x10b
net/http.HandlerFunc.ServeHTTP(0xc820180d00, 0x7f78e449ed80, 0xc856066a60, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1422 +0x3a
github.com/influxdb/influxdb/services/httpd.recovery.func1(0x7f78e6029198, 0xc8200dc370, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:804 +0x114
net/http.HandlerFunc.ServeHTTP(0xc820180d20, 0x7f78e6029198, 0xc8200dc370, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1422 +0x3a
github.com/bmizerany/pat.(*PatternServeMux).ServeHTTP(0xc820126028, 0x7f78e6029198, 0xc8200dc370, 0xc8202e6620)
    /tmp/build/src/github.com/bmizerany/pat/mux.go:109 +0x244
github.com/influxdb/influxdb/services/httpd.(*Handler).ServeHTTP(0xc82012ef00, 0x7f78e6029198, 0xc8200dc370, 0xc8202e6620)
    /tmp/build/src/github.com/influxdb/influxdb/services/httpd/handler.go:172 +0x357
net/http.serverHandler.ServeHTTP(0xc821701d40, 0x7f78e6029198, 0xc8200dc370, 0xc8202e6620)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1862 +0x19e
net/http.(*conn).serve(0xc8200a0420)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1361 +0xbee
created by net/http.(*Server).Serve
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1910 +0x3f6

goroutine 118758 [IO wait, 321 minutes]:
net.runtime_pollWait(0x7f78e6015bc0, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc82215d020, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc82215d020, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).Read(0xc82215cfc0, 0xc82013c000, 0x1000, 0x1000, 0x0, 0x7f78e8058050, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:232 +0x23a
net.(*conn).Read(0xc82a1f2048, 0xc82013c000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/net.go:172 +0xe4
net/http.(*liveSwitchReader).Read(0xc8200a0308, 0xc82013c000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:219 +0xa4
io.(*LimitedReader).Read(0xc837df9300, 0xc82013c000, 0x1000, 0x1000, 0x11, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/io/io.go:427 +0xbd
bufio.(*Reader).fill(0xc846838060)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:97 +0x1e9
bufio.(*Reader).ReadSlice(0xc846838060, 0xc81fa08d0a, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:328 +0x21a
bufio.(*Reader).ReadLine(0xc846838060, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:357 +0x53
net/textproto.(*Reader).readLineSlice(0xc8204862d0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/textproto/reader.go:55 +0x81
net/textproto.(*Reader).ReadLine(0xc8204862d0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/textproto/reader.go:36 +0x40
net/http.ReadRequest(0xc846838060, 0xc82bee4000, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/request.go:653 +0xb6
net/http.(*conn).readRequest(0xc8200a02c0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:633 +0x32f
net/http.(*conn).serve(0xc8200a02c0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1319 +0x727
created by net/http.(*Server).Serve
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1910 +0x3f6

goroutine 133124 [select]:
github.com/influxdb/influxdb/cluster.(*PointsWriter).writeToShard(0xc82012ed80, 0xc856066b20, 0xc8258e54ff, 0x12, 0xc820288b20, 0x7, 0x1, 0xc8573765b0, 0x1, 0x1, ...)
    /tmp/build/src/github.com/influxdb/influxdb/cluster/points_writer.go:306 +0x8f8
github.com/influxdb/influxdb/cluster.(*PointsWriter).WritePoints.func1(0xc85838a300, 0xc82012ed80, 0xc8592bf000, 0xc856066b20, 0xc8258e54ff, 0x12, 0xc820288b20, 0x7, 0xc8573765b0, 0x1, ...)
    /tmp/build/src/github.com/influxdb/influxdb/cluster/points_writer.go:225 +0x97
created by github.com/influxdb/influxdb/cluster.(*PointsWriter).WritePoints
    /tmp/build/src/github.com/influxdb/influxdb/cluster/points_writer.go:226 +0x3ab

goroutine 73670 [select]:
github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).autoflusher(0xc82009e0e0, 0xc858c12540)
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:604 +0x567
created by github.com/influxdb/influxdb/tsdb/engine/wal.(*Log).Open
    /tmp/build/src/github.com/influxdb/influxdb/tsdb/engine/wal/wal.go:240 +0x618

goroutine 118708 [IO wait, 321 minutes]:
net.runtime_pollWait(0x7f78e6015ec0, 0x72, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/runtime/netpoll.go:157 +0x60
net.(*pollDesc).Wait(0xc822208060, 0x72, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:73 +0x3a
net.(*pollDesc).WaitRead(0xc822208060, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/fd_poll_runtime.go:78 +0x36
net.(*netFD).Read(0xc822208000, 0xc821c24000, 0x1000, 0x1000, 0x0, 0x7f78e8058050, 0xc820010190)
    /home/philip/.gvm/gos/go1.5/src/net/fd_unix.go:232 +0x23a
net.(*conn).Read(0xc853a12000, 0xc821c24000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/net.go:172 +0xe4
net/http.(*liveSwitchReader).Read(0xc8200dc048, 0xc821c24000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:219 +0xa4
io.(*LimitedReader).Read(0xc84f8c0000, 0xc821c24000, 0x1000, 0x1000, 0x11, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/io/io.go:427 +0xbd
bufio.(*Reader).fill(0xc846838000)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:97 +0x1e9
bufio.(*Reader).ReadSlice(0xc846838000, 0xc81fff3e0a, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:328 +0x21a
bufio.(*Reader).ReadLine(0xc846838000, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/bufio/bufio.go:357 +0x53
net/textproto.(*Reader).readLineSlice(0xc820256000, 0x0, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/textproto/reader.go:55 +0x81
net/textproto.(*Reader).ReadLine(0xc820256000, 0x0, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/textproto/reader.go:36 +0x40
net/http.ReadRequest(0xc846838000, 0xc8201827e0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/request.go:653 +0xb6
net/http.(*conn).readRequest(0xc8200dc000, 0x0, 0x0, 0x0)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:633 +0x32f
net/http.(*conn).serve(0xc8200dc000)
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1319 +0x727
created by net/http.(*Server).Serve
    /home/philip/.gvm/gos/go1.5/src/net/http/server.go:1910 +0x3f6
@JulienChampseix JulienChampseix changed the title [BUG] - Panic / No protection on value having only negatif character [BUG] - Panic due no protection on value containing - Sep 29, 2015
@JulienChampseix JulienChampseix changed the title [BUG] - Panic due no protection on value containing - [BUG] - Panic due no protection on value containing '-' Sep 29, 2015
@beckettsean
Copy link
Contributor

thanks @JulienChampseix, I assume you are on 0.9.4.1?

@beckettsean beckettsean changed the title [BUG] - Panic due no protection on value containing '-' [0.9.4.1] Panic due no protection on value containing '-' Sep 29, 2015
@JulienChampseix
Copy link
Author

@beckettsean : InfluxDB version 0.9.4-rc1, branch master, commit 6d028f9

@beckettsean beckettsean changed the title [0.9.4.1] Panic due no protection on value containing '-' [0.9.4] Panic due no protection on value containing '-' Sep 30, 2015
@beckettsean
Copy link
Contributor

I confirmed that this is still present in the 0.9.4.1 release.

@beckettsean beckettsean changed the title [0.9.4] Panic due no protection on value containing '-' [0.9.4.1] Panic due no protection on value containing '-' Sep 30, 2015
@JulienChampseix
Copy link
Author

Planned to be fixed in 0.9.5 ?

@beckettsean
Copy link
Contributor

@JulienChampseix it is unscheduled.

@otoolep otoolep self-assigned this Oct 2, 2015
@otoolep otoolep added this to the 0.9.5 milestone Oct 2, 2015
@otoolep otoolep mentioned this issue Oct 2, 2015
Merged
@otoolep
Copy link
Contributor

otoolep commented Oct 2, 2015

Fixed by #4296

Thanks for the report @JulienChampseix

otoolep added a commit that referenced this issue Oct 2, 2015
@otoolep
Reject line protocol that terminates with '-'
59bbc5c 
Fixes issue #4272.
@otoolep otoolep closed this as completed Oct 2, 2015
@JulienChampseix
Copy link
Author

thanks @otoolep ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otoolep otoolep

Labels
area/writes
Projects
None yet
Milestone
0.9.5
Development

No branches or pull requests
3 participants
@otoolep @JulienChampseix @beckettsean