-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Client Precision value #4344
Comments
cc @sparrc Cameron was in this code recently, there was significant resistance to breaking changes here. |
This is slightly different than what I was looking at, this doesn't seem like it would be a very breaking change. Unless someone was setting their client's |
closed by #4361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As it stands now when writing
BatchPoints
theprecision
does not default to the client's precision. See https://github.com/influxdb/influxdb/blob/master/client/influxdb.go#L226Would it make sense to default
bp.precision
if empty toc.precision
? Might be a breaking change in some cases :( Or we could just add aClient.Precision()
method to return the precision and then use that when creating theBatchPoints
object.Thoughts?
The text was updated successfully, but these errors were encountered: