Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Client Precision value #4344

Closed
nathanielc opened this issue Oct 6, 2015 · 4 comments
Closed

Expose Client Precision value #4344

nathanielc opened this issue Oct 6, 2015 · 4 comments

Comments

@nathanielc
Copy link
Contributor

As it stands now when writing BatchPoints the precision does not default to the client's precision. See https://github.com/influxdb/influxdb/blob/master/client/influxdb.go#L226

Would it make sense to default bp.precision if empty to c.precision? Might be a breaking change in some cases :( Or we could just add a Client.Precision() method to return the precision and then use that when creating the BatchPoints object.

Thoughts?

@otoolep
Copy link
Contributor

otoolep commented Oct 6, 2015

cc @sparrc

Cameron was in this code recently, there was significant resistance to breaking changes here.

@sparrc
Copy link
Contributor

sparrc commented Oct 6, 2015

This is slightly different than what I was looking at, this doesn't seem like it would be a very breaking change. Unless someone was setting their client's precision to something other than ns and expecting it not to get applied?

@nathanielc
Copy link
Contributor Author

@sparrc If you think its not a big change then I say we just default it. See #4361

@nathanielc
Copy link
Contributor Author

closed by #4361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants