How to check which series can be read/ written

[nicolai86]

When creating new database users the cluster admin can set readFrom/ writeTo attributes.

However these attributes are not returned when executing
GET /db/anydb/users.

This makes maintaining granular series permissions a problem because I don't know which permissions a user currently has.

Now I'm wondering: was this by design, or did you just leave this out for a later point in time? Would you accept PR's which add these attributes to UserDetails ?

[jvshahid]

Hi @nicolai86, I believe this was left out when permissions where added. We love prs. Let us know if you need help with it.

[nicolai86]

@jvshahid I've finished a first draft, tests seem to pass & manual testing indicates that the attributes are returned correctly.

However I'd like some feedback regarding coding style & general structure, as I might've been going down the wrong path while implenting the changes...

[jvshahid]

@nicolai86 can you sign the cla at http://influxdb.com/community/cla.html so we can merge the pr. I'll take a look at the pr now

[jvshahid]

lgtm. Ideally I'd like to see a test to go with the pr. A test would probably require changing the go client library which we use in the tests. If you feel like making that change as well, it'd be awesome. The assertion should probably be in this test

[jvshahid]

Also, the test suite failed. Can you run make test and fix the errors

[nicolai86]

Looks like I missed some instances of the changed struct initialisation. Didn't see that >.<
I'll see to fix those. thanks.

[nicolai86]

@jvshahid I've added permission verification in 9c48cc9. Plus I hope the tests are green now.

Aside: I noticed that the tests seem to toggle locally, especially FAIL: leveldb_shard_datastore_test.go:15: LevelDbShardDatastoreSuite.SetUpSuite
Is that a problem you noticed too, or is it my setup?

[nicolai86]

odd, looks like make test is not what travis executes. lets see...

[jvshahid]

yeah, travis run the integration tests as well, I asked you to run make test because the unit tests were failing and is much faster to run

[nicolai86]

integration tests really are quite slow...

[nicolai86]

and off I go again, fixing the slow tests :)

[jvshahid]

@nicolai86 it looks like the only test that's currently failing is SingleServerSuite.TestUserWritePermissions you can run the test by doing make integration_test only=SingleServerSuite.TestUserWritePermissions

[jvshahid]

you can add verbose=on to see the output

[nicolai86]

Ah thanks for the info I was looking for that. will fix it in a second

[nicolai86]

Didn't know how to run a single integration test

[nicolai86]

@jvshahid thanks for the heads up, I'm new to golang tests /w tags (e.g. integration) and the codebase is bigger than most of my golang projects!

[nicolai86]

yay tests are green. Now back any other feedback you might have?

[jvshahid]

Closed by e5de7d3