-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We shouldn't try to take two snapshots at the same time #943
Comments
+1 |
Can be reproduced using https://github.com/dgnorton/influxdb_stress.
|
@dgnorton This might be related to the issue I saw last night. It seems that lots of |
@toddboom investigating now to see if more than one server from raft_server.go is being created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in this thread, if we tried to take two snapshots at the same time, the second snapshot will error out with
Last snapshot is not finished
.TakeSnapshot()
inraft_server.go
should lock to make sure that we don't try to take multiple snapshots at the same time. Note that taking two snapshots in a row doesn't necessarily do extra work, since raft will ignore the command if no commands were committed since the old snapshot.The text was updated successfully, but these errors were encountered: