Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dependencies from configure #978

Closed
wants to merge 1 commit into from
Closed

missing dependencies from configure #978

wants to merge 1 commit into from

Conversation

jvshahid
Copy link
Contributor

@jvshahid jvshahid commented Nov 3, 2014

It seems the build requires valgrind and hg, but it is not checked for in configure.

If valgrind isn't found, `make valgrind` will be disabled. Otherwise it
will run valgrind to make sure the parser doesn't leak any memory. If
mercurial isn't found an error will be displayed and configure will
abort.

Close #978
@jvshahid jvshahid closed this in d52ad80 Nov 5, 2014
@jvshahid jvshahid removed the review label Nov 5, 2014
jvshahid added a commit that referenced this pull request Nov 5, 2014
If valgrind isn't found, `make valgrind` will be disabled. Otherwise it
will run valgrind to make sure the parser doesn't leak any memory. If
mercurial isn't found an error will be displayed and configure will
abort.

Close #978
@toddboom toddboom deleted the fix-978 branch May 5, 2015 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants