Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin interface #1565

Merged
merged 11 commits into from
Feb 11, 2015
Merged

Admin interface #1565

merged 11 commits into from
Feb 11, 2015

Conversation

toddboom
Copy link
Contributor

Some quick stuff to make the admin interface work like it used to.

@otoolep
Copy link
Contributor

otoolep commented Feb 11, 2015

Some of the indentation looks off, and you should be able to get the admin port from the config file.

Otherwise makes sense. We can easily address the issues post merge if necessary.

On Feb 10, 2015, at 11:05 PM, Todd Persen notifications@github.com wrote:

Some quick stuff to make the admin interface work like it used to.

You can view, comment on, or merge this pull request online at:

#1565

Commit Summary

Remove admin path from .gitignore
Serve static admin assets.
Initialize the admin interface on startup.
Handle OPTIONS for CORS preflight.
File Changes

M .gitignore (2)
A admin/admin.go (51)
A admin/admin_test.go (29)
M cmd/influxd/run.go (7)
M httpd/handler.go (9)
Patch Links:

https://github.com/influxdb/influxdb/pull/1565.patch
https://github.com/influxdb/influxdb/pull/1565.diff

Reply to this email directly or view it on GitHub.

@otoolep
Copy link
Contributor

otoolep commented Feb 11, 2015

Oh, don't use "self". Not Go style.


http://www.philipotoole.com

On Feb 10, 2015, at 11:05 PM, Todd Persen notifications@github.com wrote:

Some quick stuff to make the admin interface work like it used to.

You can view, comment on, or merge this pull request online at:

#1565

Commit Summary

Remove admin path from .gitignore
Serve static admin assets.
Initialize the admin interface on startup.
Handle OPTIONS for CORS preflight.
File Changes

M .gitignore (2)
A admin/admin.go (51)
A admin/admin_test.go (29)
M cmd/influxd/run.go (7)
M httpd/handler.go (9)
Patch Links:

https://github.com/influxdb/influxdb/pull/1565.patch
https://github.com/influxdb/influxdb/pull/1565.diff

Reply to this email directly or view it on GitHub.

@toddboom
Copy link
Contributor Author

@otoolep Yeah, I mainly wanted to make sure it would come up regardless of the config for now. I'll make sure it's configurable for rc3.

@toddboom
Copy link
Contributor Author

Everything is green, self-merging. 🎸 💃

toddboom added a commit that referenced this pull request Feb 11, 2015
Update admin interface for v0.9.0
@toddboom toddboom merged commit d0a1b8d into master Feb 11, 2015
@toddboom toddboom deleted the admin-interface branch February 11, 2015 08:50
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants