fix the memory leak on the wait API #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test is broken. I'll look into it. |
The pollForIndex method starts a goroutine to check the latest index periodically. But when the HTTP request finishs, the loop is still there and the goroutine never exits. This leads to a memory leak and goroutine leak after each request to the "/wait/:index" API. The problem can be reproduced by ```ab -c 10 -t 30 http://127.0.0.1:8086/wait/1```. After several times of benchmark you'll find that the memory usage grows markedly. Signed-off-by: Shijiang Wei <mountkin@gmail.com>
mountkin
force-pushed
the
fix-memory-leak-of-wait-api
branch
from
300a32e
to
6d5ca0e
Compare
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
|
This change generally makes sense to me -- thanks @mountkin . However, can you move the new type and methods to nearer the top of the file, where is it isn't simply in the middle of other |
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
|
Hi @otoolep |
|
@mountkin very clean approach. I like it a lot. |
|
@mountkin can you sign the CLA here http://influxdb.com/community/cla.html and then we can merge. |
|
@corylanou CLA signed |
corylanou
added a commit
that referenced
this pull request
Mar 7, 2015
fix the memory leak on the wait API
corylanou
added a commit
that referenced
this pull request
Mar 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pollForIndex method starts a goroutine to check the latest index
periodically. But when the HTTP request finishs, the loop is still there
and the goroutine never exits.
This leads to a memory leak and goroutine leak after each request to the
"/wait/:index" API.
The problem can be reproduced by
ab -c 10 -t 30 http://127.0.0.1:8086/wait/1.After several times of benchmark you'll find that the memory usage grows markedly.
Signed-off-by: Shijiang Wei mountkin@gmail.com