Client should track current broker leader #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may not be a complete implementation, but should be an improvement. |
|
Looks good, can you add a test? |
otoolep
force-pushed
the
track_current_leader
branch
from
14a6382
to
e7faeee
Compare
|
Cool, let me look into a test now. |
otoolep
force-pushed
the
track_current_leader
branch
from
e7faeee
to
63aef03
Compare
|
@benbjohnson -- can you take another look? I added tests, and also fixed a bug -- the entire redirect URL was getting set in the client, when it should only have been the host (and port if present). |
otoolep
force-pushed
the
track_current_leader
branch
2 times, most recently
from
2a77f45
to
6983c4c
Compare
| return | ||
| } | ||
|
|
||
| v, err := url.Parse(u.Scheme + "://" + u.Host) |
There was a problem hiding this comment.
It's way easier to just create a new url.URL:
v := &url.URL{Scheme: u.Scheme, Host: u.Host}
There was a problem hiding this comment.
Got it -- I felt there had to be a better way.
|
One comment on the URL copy but otherwise lgtm. |
|
Thanks for the feedback @benbjohnson -- made that one final change. I will merge on green. |
otoolep
force-pushed
the
track_current_leader
branch
from
4b88c3d
to
fa4798e
Compare
otoolep
force-pushed
the
track_current_leader
branch
from
fa4798e
to
9a6f74c
Compare
|
Green build, merging now. |
otoolep
added a commit
that referenced
this pull request
Mar 6, 2015
Client should track current broker leader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.