Print config #1969
Merged
Print config #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,6 +313,11 @@ func (d *Duration) UnmarshalText(text []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // WriteConfigFile writes the config to the specified writer | |||
| func WriteConfigFile(c *Config, w io.Writer) error { | |||
There was a problem hiding this comment.
I would have expected this to be a method on the Config type. Am I missing something?
There was a problem hiding this comment.
@otoolep yeah, it was almost flip a coin for me which way to go. I do agree I think it's a method, not a function. updated.
|
Looks like a worthy change, but I do have a question about the method. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to print out the config by issuing the command:
You can also
And then this will parse/load the config you specified, and print it back out. This will be valuable to make sure people are running what they think they are running.