headers were being set after they were written #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see some test coverage that validates this so it doesn't regress in the future. |
|
Also, good catch. Adding a reference to the go library that states this: http://golang.org/pkg/net/http/#ResponseWriter |
|
@dstrek If you can add a test to this, we'll get this merged in today. |
|
added the tests, I noticed this also fixes issue #1878 |
|
+1 |
|
+1, thanks @dstrek |
otoolep
added a commit
that referenced
this pull request
Mar 18, 2015
headers were being set after they were written
|
👏 |
|
Awesome work, thanks a ton @dstrek! |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
fix(ci): add required jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1961
Headers need to be modified before calls to WriteHeader as this actually writes the response headers out on the wire.