Group by should require an aggregate #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -217,7 +217,7 @@ type Batch struct { | |||
| // Return all the measurements from the given DB | |||
| func (h *Handler) showMeasurements(db string, user *influxdb.User) ([]string, error) { | |||
| var measurements []string | |||
| results := h.server.ExecuteQuery(&influxql.Query{[]influxql.Statement{&influxql.ShowMeasurementsStatement{}}}, db, user) | |||
| results := h.server.ExecuteQuery(&influxql.Query{Statements: []influxql.Statement{&influxql.ShowMeasurementsStatement{}}}, db, user) | |||
There was a problem hiding this comment.
this was failing a vet check from a previous commit.
|
Several tests were not valid due to not having an aggregate specified. They have been updated as part of this PR. |
| @@ -585,6 +585,10 @@ func (p *Parser) parseSelectStatement(tr targetRequirement) (*SelectStatement, e | |||
| } | |||
| }) | |||
|
|
|||
| if d, _ := stmt.GroupByInterval(); stmt.IsRawQuery && d > 0 { | |||
| return nil, fmt.Errorf("group by needs at least one aggregate function") | |||
There was a problem hiding this comment.
I'm open to a better error message if someone has ideas.
There was a problem hiding this comment.
Perhaps capitalize it, to make it clear it's influxql, and I think "requires" reads better. I.e. "GROUP BY requires at least one aggregate function"
|
I have some minor feedback, which I think would improve the code. +1 on a green build. |
corylanou
force-pushed
the
groupby-requires-aggregate
branch
from
bc056d2
to
dd6bb91
Compare
corylanou
added a commit
that referenced
this pull request
Mar 20, 2015
Group by should require an aggregate
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2017