Update init script to append STDERR to log. #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we do the same for |
|
Update the CHANGELOG. Once you answer (and possibly address) the question about |
|
I wasn't sure what would happen if I tried to append to |
| @@ -9,6 +9,7 @@ | |||
| - [#2151](https://github.com/influxdb/influxdb/pull/2151): Ignore replay commands on the metastore. | |||
| - [#2156](https://github.com/influxdb/influxdb/pull/2156): Propagate error when resolving UDP address in Graphite UDP server. | |||
| - [#2163](https://github.com/influxdb/influxdb/pull/2163): Fix up paths for default data and run storage. | |||
| - [#2164](https://github.com/influxdb/influxdb/pull/2164): Append STDOUT/STDERR in initscript. | |||
There was a problem hiding this comment.
Super nit-pick: typo? initscript -> init script
benbjohnson
added a commit
that referenced
this pull request
Apr 3, 2015
Update init script to append STDERR to log.
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
fix(write): fix close logic to avoid race from read error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request changes
init.shto append standard error to the existing log, if one exists.