Always notify term change on RequestVote. #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a bug that ignored new terms from incoming vote requests when the sender's log was out of date.
|
+1, makes sense to me. |
benbjohnson
added a commit
that referenced
this pull request
Apr 9, 2015
Always notify term change on RequestVote.
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Initial pass at Confirmation Delete component * Require confirmation when deleting a dashboard * Require confirmation when deleting a task * Cleanup * Write unit test * Rewrite test to use jest mock function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously there was a bug that ignored new terms from incoming vote requests when the sender's log was out of date. This fixes it so that new terms are saved even if the vote is rejected.