Fix stream writer flushing to be thread safe. #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the raft streams so that Flush() is not called asynchronously while the snapshot is being written.
|
|
on green
| @@ -231,7 +231,9 @@ func CopyFlush(dst io.Writer, src io.Reader) (written int64, err error) { | |||
| } | |||
|
|
|||
| // Flush after write. | |||
| if dst, ok := dst.(http.Flusher); ok { | |||
There was a problem hiding this comment.
This one wasn't necessary. I mostly just don't like using http.Flusher because Flush() is such a generic concept that tying it to http seems dumb. There is no functional change here. It's just aesthetics.
|
+1, the write will now only take place is snapshotting is not. |
toddboom
added a commit
that referenced
this pull request
Apr 15, 2015
Fix stream writer flushing to be thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change fixes the raft streams so that Flush() is not called asynchronously while the snapshot is being written. Previously the
logWriterwould callFlush()while the snapshot was being written. Now it will not call flush until the snapshot is complete.