fix #2286: parse error on CREATE CONTINUOUS QUERY #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the issue? |
|
+1 |
dgnorton
added a commit
that referenced
this pull request
Apr 17, 2015
fix #2286: parse error on CREATE CONTINUOUS QUERY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be an issue in the AST code instead of the parser.
server.gocalls theString()method on the CQ so it can be sent toapplyCreateContinuousQuery, which then re-parses the query. TheString()method ontype CreateContinuousQueryStatementwas not quoting identifiers causing the parse inapplyCreateContinuousQueryto fail.Also fixed a bug in the
parser_test.go. It wasn't checking the results of parsing CQs.