Lock openTSDB and Graphite listener address #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,7 @@ type Server struct { | |||
| wg sync.WaitGroup | |||
|
|
|||
| addr net.Addr | |||
| mu sync.Mutex | |||
There was a problem hiding this comment.
Just went with a simple mutex, since this code is not accessed very often.
otoolep
changed the title
|
Fixes issues flagged by Go race detector. |
|
It's strange that this ended up as a data race. We initialize the servers outside of go routines, and then only ever read (not write) to that value. I'm going to have to look through the code to figure out why this is getting reported as a data race. In theory, even if it's really a "data race", it should never be possible to ever get dirty data from those values. I'm not overly concerned, as the little overhead this creates is only on startup anyway. +1 |
otoolep
added a commit
that referenced
this pull request
Apr 25, 2015
Lock openTSDB and Graphite listener address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.