RUnlock server after dropping series #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
add_missing_unlock
branch
from
fe1a6d2
to
eb7602b
Compare
|
+1 aside from the broken build |
This change means that lock control can use the defer call, which means there is no chance the RLock will be left locked at function exit Previously this code was more complex as it managed locks manually, since the RLock must be released to allow the "drop series" broadcast message go through.
otoolep
force-pushed
the
add_missing_unlock
branch
from
eb7602b
to
2634853
Compare
toddboom
added a commit
that referenced
this pull request
Apr 27, 2015
RUnlock server after dropping series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change now unlocks the server after dropping a series via a defer call. There was one place in the code that was not unlocking the server before returning.